[openstreetmap/openstreetmap-website] Translation scope for shared pagination (PR #5179)
Anton Khorev
notifications at github.com
Tue Sep 10 08:04:33 UTC 2024
See https://github.com/openstreetmap/openstreetmap-website/pull/5174#issuecomment-2338001493
- "Older/Newer" strings are moved to the `shared.pagination` scope.
- `shared.pagination` is ignored by `i18n-tasks`.
- Instead of receiving (multiple, currently two but possibly more in the future) translation keys, the `shared/pagination` template receives one translation scope.
- Actually it's not necessary to pass this scope in most of the cases because it can be guessed from the controller name.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5179
-- Commit Summary --
* Pass translation scope instead of keys to shared pagination
* Make i18n-tasks ignore shared pagination scope
* Guess translation scope from controller name if not provided
-- File Changes --
M app/views/diary_comments/_page.html.erb (2)
M app/views/diary_entries/_page.html.erb (2)
M app/views/issues/_page.html.erb (2)
M app/views/shared/_pagination.html.erb (5)
M app/views/traces/_page.html.erb (4)
M app/views/user_blocks/_blocks.html.erb (2)
M app/views/users/_page.html.erb (4)
M config/i18n-tasks.yml (1)
M config/locales/en.yml (32)
M test/system/issues_test.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5179.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5179.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5179
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5179 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240910/a0c674a8/attachment.htm>
More information about the rails-dev
mailing list