[openstreetmap/openstreetmap-website] Move notification code out of note update transactions (PR #5177)
Anton Khorev
notifications at github.com
Tue Sep 10 12:13:25 UTC 2024
Are `UserMailer...deliver_later` intentionally inside the transaction here? If yes, why aren't they in other places?
https://github.com/openstreetmap/openstreetmap-website/blob/a39886ac4c3deef56e0bb47a883322b635fe0e1f/app/controllers/diary_comments_controller.rb#L36-L44
https://github.com/openstreetmap/openstreetmap-website/blob/a39886ac4c3deef56e0bb47a883322b635fe0e1f/app/controllers/friendships_controller.rb#L24-L26
https://github.com/openstreetmap/openstreetmap-website/blob/a39886ac4c3deef56e0bb47a883322b635fe0e1f/app/controllers/messages_controller.rb#L49-L51
etc
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5177#issuecomment-2340526891
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5177/c2340526891 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240910/1d525294/attachment.htm>
More information about the rails-dev
mailing list