[openstreetmap/openstreetmap-website] Improved error messages and UI when importing GPS trace files (PR #5117)

Anton Khorev notifications at github.com
Fri Sep 13 10:49:15 UTC 2024


@AntonKhorev commented on this pull request.



> @@ -3,7 +3,8 @@
 <% end %>
 
 <%= bootstrap_form_for @trace, :url => { :action => "create" }, :html => { :multipart => true } do |f| %>
-  <%= f.file_field :gpx_file, :placeholder => t("helpers.file.prompt") %>
+  <%= f.file_field :gpx_file, :placeholder => t("helpers.file.prompt"),
+                              :help => ".gpx, .tar.gz, .tar.bz2, .tar, .zip, .gpx.gz, .gpx.bz2" %>

Are you not putting the help string into `en.yml` [help scope](https://github.com/openstreetmap/openstreetmap-website/blob/0423d18a8f5b232aa2a08b55351bee553047fb81/config/locales/en.yml#L153) on purpose, for it not to show up in translations because there's nothing to translate?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5117#pullrequestreview-2302802319
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5117/review/2302802319 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240913/e6b3292e/attachment.htm>


More information about the rails-dev mailing list