[openstreetmap/openstreetmap-website] Move History and Export buttons to secondary nav (PR #5151)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -412,6 +412,9 @@ $(document).ready(function () {
 
     if (OSM.router.route(this.pathname + this.search + this.hash)) {
       e.preventDefault();
+      if (this.pathname !== "/directions") {

Why should it reach `this.pathname !== "/directions"`?

If you're at app\assets\javascripts\index\search.js:13:5, you have the menu open. And you want it to stay open because you're switching from the search form to the directions form. `if (this.pathname !== "/directions") ...` closes the menu, something you don't want at this point.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5151#discussion_r1759070379
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5151/review/2303435363 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240913/f372e260/attachment-0001.htm>