[openstreetmap/openstreetmap-website] Drop creation_ip column (PR #5212)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> @@ -50,6 +49,8 @@ class User < ApplicationRecord
   require "digest"
   include AASM
 
+  self.ignored_columns += ["creation_ip"]

What `strong_migrations` wants you to do is

1. stop using the column and start ignoring it like in #2432
2. remove the column like in #2439
3. stop ignoring the column like in #2461 because it doesn't exist

Here instead you removing the column and then you start ignoring it. What is ignoring supposed to achieve if the column already doesn't exist?

(And if you don't care about `strong_migrations` you also wouldn't ignore the column.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5212#pullrequestreview-2304442764
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5212/review/2304442764 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240914/530ce509/attachment.htm>