[openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)

[Anton Khorev]

We've been including stack backtraces in gpx failure notifications since https://github.com/openstreetmap/openstreetmap-website/commit/93dab8a1272f8c807da841c0a55b37f74b65b8c3, but they are not useful for xml parse errors. If your file can't be parsed, the error is inside it, not in the code that called the parser.

Not sending the backtrace in case of xml errors will kind of fix #2630. We're still not going to check file types but the error message is going to be limited to a useful part like:

```
Fatal error: Start tag expected, '<' not found at :1.
```
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5226

-- Commit Summary --

  * Don't include stack backtraces on xml errors when importing traces

-- File Changes --

    M app/jobs/trace_importer_job.rb (4)
    A test/gpx/fixtures/jpg.gpx (0)
    M test/jobs/trace_importer_job_test.rb (15)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5226.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5226.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5226 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240919/b6752778/attachment.htm>