[openstreetmap/openstreetmap-website] Don't include stack backtraces on xml errors when importing traces (PR #5226)
Anton Khorev
notifications at github.com
Fri Sep 20 13:58:33 UTC 2024
> Regarding "Entity: line 1: parser error : Start tag expected, '<' not found" message, it's introduced by adding test_parse_error_notification which tries to load JPG file with XML reader.
Do you think that if you upload a binary file without this PR, the error won't be printed?
> Perhaps the best would be to redirect stderr to temporary file which could be printed if this test fails?
We don't need this error printed because we're additionally logging it with Rails logger.
I disabled xml library error writing for this case but there's also another path for multi-file archives with different errors. And there's also a changeset diff reader elsewhere.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5226#issuecomment-2363806999
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5226/c2363806999 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240920/8e3c01a5/attachment-0001.htm>
More information about the rails-dev
mailing list