[openstreetmap/openstreetmap-website] Allow Filtering of Notes by Status (Open/Closed) on User Profile (PR #5239)
Emin Kocan
notifications at github.com
Thu Sep 26 02:51:36 UTC 2024
This PR implements a basic filtering functionality for the notes displayed on a user's profile page, addressing part of the long-standing request from issue #832.
#### Key Changes:
- Introduced tabs for filtering notes by status (Open/Closed) on the user profile page.
- When no status is specified in the URL, the **Open Notes** tab is selected and displayed by default.
- The URL is updated with a `status` parameter to reflect the current filter state, ensuring clarity for users and enabling easy sharing/bookmarking of filtered views.
- Maintains existing pagination and ordering logic, ensuring consistency with the current note display behavior.
#### Future Steps:
This is the first step toward more comprehensive sorting and filtering functionalities, such as sorting by creation date, solved date, and more, as requested in #832. By implementing this, we improve the visibility of open (unresolved) notes while preserving the ability to view both open and closed notes for users accustomed to that behavior.
#### Screenshots:
<img width="1133" alt="Screenshot 2024-09-26 at 04 46 21" src="https://github.com/user-attachments/assets/a78a2f03-4da3-4da6-80f0-91a836943dba">
<img width="1136" alt="Screenshot 2024-09-26 at 04 46 39" src="https://github.com/user-attachments/assets/3bf6680b-48ca-44ef-8dbc-5e7a51c66c14">
<img width="450" alt="Screenshot 2024-09-26 at 04 46 55" src="https://github.com/user-attachments/assets/119d950a-332b-4ab8-9be4-ad59c10464db">
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5239
-- Commit Summary --
* Add filtering for notes by status on user profile
-- File Changes --
M app/controllers/notes_controller.rb (4)
M app/views/notes/index.html.erb (9)
M config/locales/en.yml (2)
M db/structure.sql (7)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5239.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5239.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5239
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5239 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240925/4c80b5c0/attachment.htm>
More information about the rails-dev
mailing list