[openstreetmap/openstreetmap-website] Add locale selector (PR #5201)

David Tsiklauri notifications at github.com
Thu Sep 26 08:08:03 UTC 2024


@nertc commented on this pull request.



> @@ -76,6 +85,15 @@
           <li><%= link_to t("layouts.copyright"), copyright_path, :class => "dropdown-item" %></li>
           <li><%= link_to t("layouts.help"), help_path, :class => "dropdown-item" %></li>
           <li><%= link_to t("layouts.about"), about_path, :class => "dropdown-item" %></li>
+          <li>
+            <% if current_user && current_user.id %>
+              <%= link_to(preferences_path) do %>
+                <%= render "shared/language_selector", :hoverable => true, :black => true, :classes => "dropdown-item", :disabled => true %>

I've updated this PR. Tried several solutions and current one needed the smallest and cleanest code. Also, one CSS class was added `.text-transparent` to make text and background of the `<select>` tag visually hidden but still focusable.

Language selector will no more be moved to the compact menu. Visually it doesn't take much space and contextually it's more relevant to be as an icon than as a compacted menu button.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5201#discussion_r1776583692
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5201/review/2330445295 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240926/3e945403/attachment-0001.htm>


More information about the rails-dev mailing list