[openstreetmap/openstreetmap-website] Disabling asynchronous Map data layer rendering (PR #5877)
Roman Deev
notifications at github.com
Wed Apr 2 11:00:44 UTC 2025
Full discussion here: https://github.com/openstreetmap/openstreetmap-website/pull/5009#issuecomment-2722980833 But I'll duplicate the comment here.
https://github.com/openstreetmap/openstreetmap-website/pull/5009 brought two problems:
1. When moving the map, a white flash occurs and all objects on the map are redrawn:
https://github.com/user-attachments/assets/3c87c769-174c-4513-a5be-115eb9517bb8
2. Rendering slowed down. What used to occupy ~400ms now occupies ~1.3s. Hiding a data layer was previously performed on ~100ms, now ~1.5s (!)
Both problems arise due to the fact that before that the redrawing of the map was performed only once, after the completion of the removal/adding of objects to the SVG-element of the map.
--
This PR only removes asynchronous rendering. The loader that shows downloading data near the checkbox remains.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5877
-- Commit Summary --
* Disabling asynchronous data layer rendering
-- File Changes --
M app/assets/javascripts/leaflet.map.js (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5877.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5877.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5877
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5877 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250402/d0d3d910/attachment.htm>
More information about the rails-dev
mailing list