[openstreetmap/openstreetmap-website] Remove manual edit after 4-second timeout on welcome page (PR #5885)
Anton Khorev
notifications at github.com
Fri Apr 4 06:26:29 UTC 2025
Go to `/welcome` and click *start mapping*:

What's going to happen is that if you didn't give the geolocation permission yet:
1. the permission dialog pops up
2. if you fail to react to it in four seconds, you get redirected to the map view
Four seconds is probably too short. And why do you need any timeout here? Supposedly this was a workaround for [a Firefox bug](https://bugzilla.mozilla.org/show_bug.cgi?id=675533) but it was fixed years ago.
This PR removes the timeout.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5885
-- Commit Summary --
* Remove manual edit after 4-second timeout on welcome page
-- File Changes --
M app/assets/javascripts/welcome.js (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5885.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5885.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5885
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5885 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250403/14e474d8/attachment.htm>
More information about the rails-dev
mailing list