[openstreetmap/openstreetmap-website] Remove invalid setStyle from data layer (PR #5892)
Anton Khorev
notifications at github.com
Sat Apr 5 15:30:43 UTC 2025
Look at data layer. Notice that everything is blue:

Now look at the `setStyle` call that I remove in this PR. Notice that the colors are supposed to be black, red, green. It's broken since https://github.com/openstreetmap/openstreetmap-website/commit/5e9ab5bc5edb63b7ab7719fa989a18f52e3637a2, but I'm not fixing it because those colors don't look very well over the tiles and everyone probably got used to blue.
The argument to `setStyle` is invalid; and when used on feature group layer, `setStyle` should be called after adding the geometry.
https://leafletjs.com/reference.html#featuregroup-setstyle
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5892
-- Commit Summary --
* Remove invalid setStyle from data layer
-- File Changes --
M app/assets/javascripts/index/layers/data.js (15)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5892.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5892.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5892
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5892 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250405/b1d56519/attachment.htm>
More information about the rails-dev
mailing list