[openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

Anton Khorev notifications at github.com
Sat Apr 5 17:34:50 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -22,8 +18,11 @@
   <div class='col-sm'>
     <h3 class='fs-5'><%= t "site.welcome.add_a_note.title" %></h3>
     <p><%= t "site.welcome.add_a_note.para_1" %></p>
-    <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon => tag.a(:class => "icon note bg-dark rounded-1",
-                                                                                :title => t("javascripts.site.createnote_tooltip")) %></p>
+    <p><%= map_hash = params[:lat].to_f && params[:lon].to_f ? "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}" : ""

Do you have to change the link in this pull request, if you're not adding this link to the welcome page?

`params[:lat].to_f && params[:lon].to_f` evaluates to `0.0` which is true in Ruby.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2744952999
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5752/review/2744952999 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250405/db7a0058/attachment.htm>


More information about the rails-dev mailing list