[openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

Anton Khorev notifications at github.com
Sat Apr 5 18:19:41 UTC 2025


@AntonKhorev commented on this pull request.



> +    <p><%= map_hash = params[:lat].to_f && params[:lon].to_f ? "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}" : ""
+           t ".how_to_help.add_a_note.instructions_1_html",
+             :note_icon => link_to(render(:partial => "layouts/note_icon"),
+                                   "#{new_note_path}#{map_hash}",
+                                   :title => t("javascripts.site.createnote_tooltip")) %></p>

> as the JS uses the icon class

And what's the problem with the icon class?

```suggestion
    <p><%= t ".how_to_help.add_a_note.instructions_1_html",
             :note_icon => tag.a(render(:partial => "layouts/note_icon"),
                                 :class => "icon note d-inline-flex align-bottom bg-dark rounded-1 text-white",
                                 :title => t("javascripts.site.createnote_tooltip")) %></p>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2744960741
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5752/review/2744960741 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250405/b873a749/attachment-0001.htm>


More information about the rails-dev mailing list