[openstreetmap/openstreetmap-website] Show valid username in header when renaming (PR #5896)

[rkoeze]

rkoeze left a comment (openstreetmap/openstreetmap-website#5896)

Nice find!  I reproduced the error on main and then confirmed the fix running this branch.

I wonder if it might make sense to rename the `display_name` field in the test to  `Valid Display Name`. That way if the test fails to find the valid username you get an error that more clearly suggests the element that could not be found. So instead of:
```
expected to find button "Valid User" that is not disabled but there were no matches
```
You get:

```
expected to find button "Valid Display Name" that is not disabled but there were no matches
```
Feel free to ignore, just a suggestion.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5896#issuecomment-2781186520
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5896/c2781186520 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250405/82d0e0e1/attachment.htm>