[openstreetmap/openstreetmap-website] Prefer COPY to ADD in Dockerfile (PR #5897)
rkoeze
notifications at github.com
Sun Apr 6 03:09:36 UTC 2025
<!--
Please read the contributing guidelines before making a PR:
https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md
Pay particular attention to the section on how to present PRs:
https://github.com/openstreetmap/openstreetmap-website/blob/master/CONTRIBUTING.md#pull-requests
-->
### Description
Updates the Dockerfile to use `COPY` instead of `ADD`. From [Docker's best practices doc](https://docs.docker.com/build/building/best-practices/#add-or-copy):
> You'll mostly want to use COPY for copying files from one stage to another in a multi-stage build.
and:
> The ADD instruction is best for when you need to download a remote artifact as part of your build.
Since we're just copying files, let's prefer `COPY`.
### How has this been tested?
I rebuilt my docker container with these new changes and was able to successfully navigate the app locally.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5897
-- Commit Summary --
* Prefer COPY to ADD
-- File Changes --
M Dockerfile (6)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5897.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5897.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5897
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5897 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250405/fd463f8a/attachment.htm>
More information about the rails-dev
mailing list