[openstreetmap/openstreetmap-website] Move directions step numbering out of engine-specific code (PR #5898)

Anton Khorev notifications at github.com
Sun Apr 6 10:35:02 UTC 2025


Writing step numbers is currently the responsibility of each routing engine:

![image](https://github.com/user-attachments/assets/17a2fe98-158f-4446-873d-653ac875f74b)

But that shouldn't be the case. Writing the numbers outside would later help to stop constructing html by concatenation.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5898

-- Commit Summary --

  * Move directions step numbering out of engine-specific code

-- File Changes --

    M app/assets/javascripts/index/directions.js (6)
    M app/assets/javascripts/index/directions/fossgis_osrm.js (16)
    M app/assets/javascripts/index/directions/fossgis_valhalla.js (5)
    M app/assets/javascripts/index/directions/graphhopper.js (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5898.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5898.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5898
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5898 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250406/b8f5bbc3/attachment.htm>


More information about the rails-dev mailing list