[openstreetmap/openstreetmap-website] Draft: Refactor confirmations controller (PR #5895)

[rkoeze]

@rkoeze commented on this pull request.



>  
-  def confirm
-    if request.post?
-      user = User.find_by_token_for(:new_user, params[:confirm_string])
+  def show
+    if params[:confirm_string]
+      user = User.lookup_by_confirmation_token(params[:confirm_string])
 
       if !user

This was one of the bigger changes in terms of UX. Now if a user can't be found or their account has already been confirmed, they are redirected to the root path in both the new account and email change cases.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5895#pullrequestreview-2745427245
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5895/review/2745427245 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250406/30c9a6f2/attachment-0001.htm>