[openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

Marwin Hochfelsner notifications at github.com
Thu Apr 10 10:53:02 UTC 2025


@hlfan commented on this pull request.



> @@ -93,6 +100,11 @@ OSM = {
       mapParams.lon = params.get("mlon");
       mapParams.lat = params.get("mlat");
       mapParams.zoom = params.get("zoom") || 12;
+    } else if (geoURI.has("geo") && geoURI.has("u") && !geoURI.has("z")) {
+      mapParams.bounds = L.latLng(geoURI.get("geo").split(",")).toBounds(geoURI.get("u") * 4);
+    } else if (geoURI.has("geo")) {
+      [mapParams.lat, mapParams.lon] = geoURI.get("geo").split(",");
+      mapParams.zoom = geoURI.getAll("z").reduce((out, cur) => parseInt(cur, 10) || out, 12);

I think you've added enough constraints that I have to switch to an overly explicit implementation. Have fun pinpointing the tests you don't like.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#discussion_r2037071848
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5736/review/2756242104 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250410/0f87b950/attachment.htm>


More information about the rails-dev mailing list