[openstreetmap/openstreetmap-website] Add kilometers/miles switch to directions (PR #5915)

[Anton Khorev]

@AntonKhorev commented on this pull request.



>      } else {
-      return OSM.i18n.t("javascripts.directions.distance_km", { distance: Math.round(m / 1000) });
+      const ft = m / ftSize;
+      const mi = m / miSize;
+      if (ft < 1000) {

It was at 0.2 miles in https://github.com/openstreetmap/openstreetmap-website/pull/1747 which is about 1000 feet:

https://github.com/openstreetmap/openstreetmap-website/blob/ff73d379a723060870f591451f4092343a3b4077/app/assets/javascripts/index/directions.js#L151

It depends on what is the goal. If the goal is not to have too large number in minor units, the boundary can be the same number.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2037939055
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5915/review/2757709842 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250410/e7546f46/attachment.htm>