[openstreetmap/openstreetmap-website] Add kilometers/miles switch to directions (PR #5915)
Anton Khorev
notifications at github.com
Fri Apr 11 13:21:15 UTC 2025
@AntonKhorev commented on this pull request.
> } else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance: Math.round(m / 1000) });
+ const ft = m / ftSize;
+ const mi = m / miSize;
+ if (ft < 1000) {
I'm not doing 0.1 miles because it's going to one significant digit too soon. I tried different boundaries and I chose:
- `minorValue < 1000 || majorValue < 0.5` for total distance
- `minorValue < 1500 || majorValue < 0.5` for step distance
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2039555913
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5915/review/2760354939 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250411/a82a1a16/attachment.htm>
More information about the rails-dev
mailing list