[openstreetmap/openstreetmap-website] Update to rack 3 (PR #5923)
mmd
notifications at github.com
Sun Apr 13 07:34:58 UTC 2025
@mmd-osm commented on this pull request.
> @@ -247,7 +247,7 @@ def respond_to_timeout
# To work round this we call rewind on the body here, which is added
# as a filter, to force it to be fetched from Apache into a file.
def fetch_body
- request.body.rewind
+ request.body&.rewind
I'm assuming this might be something unit test specific. A non-existing request body used to be represented by an empty string, and is now nil.
When running the code in rails server, request body will be #<Puma::NullIO:0x0000xxx> in this case. This wouldn't trigger the undefined method 'rewind' for nil error anymore.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5923#discussion_r2041066463
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5923/review/2762705460 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250413/7e32cbf1/attachment.htm>
More information about the rails-dev
mailing list