[openstreetmap/openstreetmap-website] Update to rack 3 (PR #5923)

Tom Hughes notifications at github.com
Tue Apr 15 11:08:13 UTC 2025


@tomhughes commented on this pull request.



> @@ -247,7 +247,7 @@ def respond_to_timeout
   # To work round this we call rewind on the body here, which is added
   # as a filter, to force it to be fetched from Apache into a file.
   def fetch_body
-    request.body.rewind
+    request.body&.rewind

It seems rack 3 has a change in it's mock requests that tests use so that `body` is now `nil` for requests like GET that don't have any body - hence what I had to add that to avoid issues.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5923#discussion_r2044273521
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5923/review/2767838495 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250415/a81be51b/attachment.htm>


More information about the rails-dev mailing list