[openstreetmap/openstreetmap-website] Replace CC by-sa license link with ODbL in history feeds (PR #5933)
Anton Khorev
notifications at github.com
Wed Apr 16 08:42:17 UTC 2025
@AntonKhorev commented on this pull request.
> @@ -10,9 +10,7 @@ atom_feed(:language => I18n.locale, :schema_date => 2009,
feed.logo image_url("mag_map-rss2.0.png")
feed.rights :type => "xhtml" do |xhtml|
- xhtml.a :href => "https://creativecommons.org/licenses/by-sa/2.0/" do |a|
- a.img :src => image_url("cc_button.png"), :alt => "CC by-sa 2.0"
- end
+ xhtml.a "Open Data Commons Open Database License", :href => "https://opendatacommons.org/licenses/odbl/"
> a localizable string
For that to have any effect we need to include `locale=xx` in feed links. Currently we don't.
Another option is to have the entire `<rights>` contents in `Settings` because maybe you have an appropriate "button" image, maybe you don't. Or maybe you want something more complicated than just one license. What's the correct license for OpenHistoricalMap? CC0 + some other CCs in some other cases. Their [feed](https://www.openhistoricalmap.org/history/feed) says CC by-sa like it used to be on OSM, probably because nobody looks at it.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5933#discussion_r2046412798
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5933/review/2771684614 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250416/d47ecfea/attachment-0001.htm>
More information about the rails-dev
mailing list