[openstreetmap/openstreetmap-website] Add profile location (PR #5302)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -157,7 +157,11 @@ def search_osm_nominatim_reverse
                     :type => object_type, :id => object_id)
     end
 
-    render :action => "results"
+    respond_to do |format|
+      format.html { render :action => "results" }
+      format.json { render :json => @results }
+      format.any { render :action => "results" }

Presumably we don't really need the first line here if the render is just the same as the any case?

> @@ -143,6 +143,16 @@
       <div class='text-body-secondary'>
         <small>
           <dl class="list-inline">
+            <% if @user.home_location_name&.strip.present? %>
+              <dt class="list-inline-item m-0">
+                <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-geo-alt-fill" viewBox="0 0 16 16">

I think I'd be inclined to add `align-bottom` to the classes here - it seems to give slightly better vertical centring of the icon relative to the text for me?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2776420502
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5302/review/2776420502 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250417/7213ba7c/attachment-0001.htm>