[openstreetmap/openstreetmap-website] Don't visit profile page after tested profile location update (PR #5955)
Anton Khorev
notifications at github.com
Sat Apr 26 16:07:21 UTC 2025
The system test from #5302 sometimes fails:
```
Failure:
UserLocationChangeTest#test_User_can_change_their_location [test/system/user_location_change_test.rb:20]:
expected to find text "Test Location" in "OpenStreetMap\nEdit\nHistory\nExport\nGPS Traces\nUser Diaries\nCommunities\nCopyright\nHelp\nAbout\nUser 597\nUser 597\nMy Edits 0\nMy Notes 0\nMy Traces 0\nMy Diary 0\nMy Comments 0\nMy Account\nMapper since: April 26, 2025 Last map edit: No activity yet\nEdit Profile"
bin/rails test test/system/user_location_change_test.rb:8
```
It could be because it leaves the edit profile page before sending the update request, or because arriving at the view profile page before the changes propagate. But `visit user_path(user)` is unnecessary because clicking *Update Profile* redirects you to that page.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5955
-- Commit Summary --
* Don't visit profile page after tested profile location update
-- File Changes --
M test/system/user_location_change_test.rb (12)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5955.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5955.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5955
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5955 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250426/b5398eb4/attachment-0001.htm>
More information about the rails-dev
mailing list