[openstreetmap/openstreetmap-website] Already logged in warning (PR #5957)

Marwin Hochfelsner notifications at github.com
Sat Apr 26 21:54:58 UTC 2025


@hlfan commented on this pull request.



>      $("#referer").val($("#referer").val() + location.hash);
+    $("#referer_link").prop("href", $("#referer_link").prop("href") + location.hash);

The insistence on using jQuery reduces the legibility:
``` suggestion
    $("#referer")[0].value += location.hash;
    $("#referer_link")[0].hash = location.hash;
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5957#pullrequestreview-2796456086
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5957/review/2796456086 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250426/5e4d00a7/attachment-0001.htm>


More information about the rails-dev mailing list