[openstreetmap/openstreetmap-website] Fix outputting route before directions sidebar is loaded (PR #5961)

Anton Khorev notifications at github.com
Mon Apr 28 20:37:06 UTC 2025


@AntonKhorev commented on this pull request.



>  
-      map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng);
-    }
+    map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng);

And after that `OSM.loadSidebarContent` resets it.

`map.setSidebarOverlaid` is here to counter sidebar flickering the conditions for which I don't exactly remember. So it's possible that it's not needed anymore, but not because `page.load` calls it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5961#discussion_r2064557663
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5961/review/2800726354 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250428/7378f7c1/attachment-0001.htm>


More information about the rails-dev mailing list