[openstreetmap/openstreetmap-website] Split interactive history layer into areas and borders above areas (PR #5963)

Tom Hughes notifications at github.com
Tue Apr 29 23:10:31 UTC 2025


@tomhughes commented on this pull request.



>      this._highlightLayer.clearLayers();
 
     for (const changeset of this._changesets.values()) {
-      const rect = L.rectangle(changeset.bounds, this._getInteractiveStyle(changeset));
+      const rect = L.rectangle(changeset.bounds, this._getAreaStyle(changeset));
+      rect.id = changeset.id;
+      rect.addTo(this._areaLayer);
+    }
+
+    for (const changeset of this._changesets.values()) {
+      const rect = L.rectangle(changeset.bounds, this._getBorderStyle(changeset));

> We can't because the order of `<path>` elements inside Leaflet's svg layer depends on the order of `addTo` calls. Even if the rectangles are added to different feture groups, their `<path>`s end up in the same `<svg>` element.

Oh right... I assumed that was the point of having separate layer groups so that it would order the groups in the order they were added. What's the point of splitting it into two groups then?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#discussion_r2067562799
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5963/review/2805290646 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250429/91eb097f/attachment.htm>


More information about the rails-dev mailing list