[openstreetmap/openstreetmap-website] Generic scrollable numbered pagination (PR #6314)
Anton Khorev
notifications at github.com
Sun Aug 10 19:17:56 UTC 2025
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6314
-- Commit Summary --
* Rename element_versions_pagination helper to numbered_pagination
* Rename top/active version parameters to top/active page
* Change version references internal to helper test to page references
* Allow customizing active page id
* Add aria-current="page" to current page links
* Generalize links to active pages
* Add numbered_pagination css class for event listeners
* Remove version navigation list ids
* Store shadow effects in jQuery data of dom elements
* Allow arbitrary options for numbered pagination links
-- File Changes --
M app/assets/javascripts/index/element.js (6)
M app/assets/javascripts/numbered_pagination.js (42)
M app/helpers/numbered_pagination_helper.rb (87)
M app/views/elements/show.html.erb (4)
M app/views/old_elements/_actions.html.erb (4)
M app/views/old_elements/index.html.erb (2)
M test/helpers/numbered_pagination_helper_test.rb (366)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6314.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6314.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6314
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6314 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250810/7f3f02fc/attachment.htm>
More information about the rails-dev
mailing list