[openstreetmap/openstreetmap-website] Lazy loading relation members (PR #6326)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -0,0 +1,13 @@
+<turbo-frame id="<%= frame_id %>">
+  <% if relation.redacted? && !params[:show_redactions] %>

Can this ever happen? If it's redacted and we're not showing redactions then we won't have generated the frame will we?

I guess there's an issue that somebody could request the frame manually to try and see the redactions but the controller could just reject requests for a frame for a redacted relation unless the show redactions flag is set?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6326#pullrequestreview-3126427501
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6326/review/3126427501 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250817/3b82c401/attachment-0001.htm>