[openstreetmap/openstreetmap-website] Update num_changes when backfilling changesets (PR #6361)

Pavel Zbytovský notifications at github.com
Thu Aug 28 13:46:20 UTC 2025


zbycz left a comment (openstreetmap/openstreetmap-website#6361)

@mmd-osm I tried a test against the Test API. I created a new node + its relation  ([changeset](https://master.apis.dev.openstreetmap.org/changeset/437816)), and then tried to change only the relation, but "open" the node in the UI as well and make no changes to it – https://master.apis.dev.openstreetmap.org/changeset/437817. Due to https://github.com/zbycz/osmapp/issues/1319 it sends also the node - where no changes happened, but the version increased nevertheless.

The exact osc sent in this case was:
```
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<osmChange generator="OsmAPP" version="0.6">
    <create/>
    <modify>
        <node id="4360282798" lon="14.25774" lat="49.661" version="1" changeset="437817">
            <tag k="climbing" v="route_bottom"/>
            <tag k="name" v="new node"/>
            <tag k="sport" v="climbing"/>
        </node>
        <relation id="4305234299" version="1" changeset="437817">
            <tag k="climbing" v="crag"/>
            <tag k="name" v="new relation - changed (but node unchanged)"/>
            <tag k="site" v="climbing"/>
            <tag k="sport" v="climbing"/>
            <tag k="type" v="site"/>
            <member type="node" ref="4360282798" role=""/>
        </relation>
    </modify>
    <delete if-unused="true"/>
</osmChange>
```


Could the issue be, that `current_num_changes` counts only the objects where some values (tags/location/members) had really changed, but the backfill (`correct_num_changes`) counts merely the number of objects in the changeset? So it counts all the submitted items, even though some were not changed at all?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6361#issuecomment-3233572649
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6361/c3233572649 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250828/8eb64943/attachment.htm>


More information about the rails-dev mailing list