[openstreetmap/openstreetmap-website] Show tag changes in object history view (PR #6448)

Pablo Brasero notifications at github.com
Tue Dec 2 14:41:29 UTC 2025


@pablobm commented on this pull request.

I think this is ok. The initial refactor and the markup-generating code make things difficult to follow, but it can be followed a bit better when going commit-by-commit.

If anything, the markup generation could be untangled a bit. I gave it a shot at https://github.com/iandees/openstreetmap-website/compare/highlight-tag-changes-in-history...pablobm:openstreetmap-website:highlight-tag-changes-in-history and I think it's an improvement there. Not sure if it worth pursuing elsewhere, after playing with it a bit more.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#pullrequestreview-3530490262
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6448/review/3530490262 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251202/1efe585d/attachment.htm>


More information about the rails-dev mailing list