[openstreetmap/openstreetmap-website] Fix inconsistent context menu icons (Issue #6485) (PR #6571)
Pablo Brasero
notifications at github.com
Fri Dec 5 11:44:25 UTC 2025
pablobm left a comment (openstreetmap/openstreetmap-website#6571)
Thank you for the update @aNsHuL5217. I think those icons look better now.
I am ok with the current result. I think this is a step in the right direction, and the questions I raised are each complex and can take time to resolve so they are better worked separately.
A couple of details:
- There are a number of changes that are unrelated to the substance of the PR. I think you ran a linter and it changed more things than needed? Please remove those.
- After that, can you please squash all the commits into a single one? I'm realising this is not that clear in the contribution guidelines, we'll have to update that.
Also a general piece of advice for contributions in any project: avoid using `master` (or `main` or whatever a project uses) as your working branch, as that makes it a bit more difficult to work with.
Finally, just out of curiosity if it's ok: how are you running the project in your computer? Docker, rbenv, other? Just to have an idea of what people are using, particularly those new to the project.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6571#issuecomment-3616553490
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6571/c3616553490 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251205/a953bec7/attachment-0001.htm>
More information about the rails-dev
mailing list