[openstreetmap/openstreetmap-website] Fix some dark mode colors desyncing (PR #6576)

Andy Allan notifications at github.com
Mon Dec 8 11:58:14 UTC 2025


gravitystorm left a comment (openstreetmap/openstreetmap-website#6576)

We're talking about several different things here when it comes to contrast. There's the foreground-background contrast levels of the text (in various states, hover, active, dark mode etc), and the background-background contrast between hovered and unhovered states.

@mmd-osm what this PR did was remove all the attempts to twiddle things. We were starting to layer fixes on top of fixes. Instead, we now just use the [bootstrap dropdown component defaults](https://getbootstrap.com/docs/5.3/components/dropdowns/). 

The background hover highlighting is subtle, but that's coming from upstream. I wouldn't call the end result "worse" because it fixed various other problems.

If we want to change the backgrounds of hovered items in dropdown menus, i.e. override the bootstrap defaults, then let's discuss that and make it work for all the dropdown menus consistently, rather than trying to adjust this one separately.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6576#issuecomment-3626553352
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6576/c3626553352 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251208/994a57a0/attachment.htm>


More information about the rails-dev mailing list