[openstreetmap/openstreetmap-website] Use red heart in donate attribution (PR #6601)

Minh Nguyễn notifications at github.com
Wed Dec 10 02:26:17 UTC 2025


@1ec5 commented on this pull request.



> @@ -59,7 +59,7 @@ L.OSM.Map = L.Map.extend({
         }).prop("outerHTML")
       });
 
-      attribution += credit.donate ? " ♥ " : ". ";
+      attribution += credit.donate ? " ♥️ " : ". ";

The period is there because the attribution lines for each of the third-party layers’ attribution lines lack a period at the end. This is “Lego localization” that doesn’t work as well in some languages that use other punctuation. The period should be moved to each of the attribution strings, such as:

https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/config/locales/en.yml#L3595

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6601#discussion_r2604963172
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6601/review/3560451585 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251209/3ccf15bc/attachment.htm>


More information about the rails-dev mailing list