[openstreetmap/openstreetmap-website] Migrate the dashboard entry page from leaflet to maplibre (PR #6504)

Marwin Hochfelsner notifications at github.com
Thu Dec 11 06:45:25 UTC 2025


@hlfan requested changes on this pull request.

We still need to make ESLint happy, too.

> +  let offset = {
+    'bottom': [0, -45],
+    'bottom-left': [0, -45],
+    'bottom-right': [0, -45],
+    'top': [0, 5],
+    'top-left': [0, 5],
+    'top-right': [0, 5],
+    // our marker is bigger at the top, but this does not attach there -> tucked 2px more
+    'right': [-15, -10],
+    'left': [15, -10]
+  };
+  return new maplibregl.Popup({ offset }).setHTML(content);
+}

```suggestion
  const offset = {
    "bottom": [0, -45],
    "bottom-left": [0, -45],
    "bottom-right": [0, -45],
    "top": [0, 5],
    "top-left": [0, 5],
    "top-right": [0, 5],
    // our marker is bigger at the top, but this does not attach there -> tucked 2px more
    "right": [-15, -10],
    "left": [15, -10]
  };
  return new maplibregl.Popup({ offset }).setHTML(content);
};
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3565964936
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6504/review/3565964936 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251210/83ff7b76/attachment.htm>


More information about the rails-dev mailing list