[openstreetmap/openstreetmap-website] Improve linkification scoping (PR #6612)

Marwin Hochfelsner notifications at github.com
Thu Dec 18 15:44:20 UTC 2025


@hlfan commented on this pull request.



> +                          .uniq
+                          .filter_map do |target|
+      r = RichText.new("text", "foo #{target} bar")
+      links = Nokogiri::HTML::DocumentFragment.parse(r.to_html).css("a")
+      target if links.empty?
+    end
+    key_links = WIKI_PAGES.values
+                          .flat_map { |l| l["key"]&.keys }
+                          .filter { |key| key && !%r{\*:|/|\*$}.match?(key) }
+                          .map { |l| "#{l}=*" }
+                          .uniq
+                          .filter_map do |target|
+      r = RichText.new("text", "foo #{target} bar")
+      links = Nokogiri::HTML::DocumentFragment.parse(r.to_html).css("a")
+      target if links.empty?
+    end

...actually, the one CJK tag `shop=園芸店` is already redirected to https://osm.wiki/wiki/JA:Tag:shop=agrarian, might as well drop it here too.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6612#discussion_r2631603708
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6612/review/3593657135 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251218/071475ae/attachment.htm>


More information about the rails-dev mailing list