[openstreetmap/openstreetmap-website] Improve linkification scoping (PR #6612)
Tom Hughes
notifications at github.com
Thu Dec 18 16:56:44 UTC 2025
@tomhughes commented on this pull request.
> + .uniq
+ .filter_map do |target|
+ r = RichText.new("text", "foo #{target} bar")
+ links = Nokogiri::HTML::DocumentFragment.parse(r.to_html).css("a")
+ target if links.empty?
+ end
+ key_links = WIKI_PAGES.values
+ .flat_map { |l| l["key"]&.keys }
+ .filter { |key| key && !%r{\*:|/|\*$}.match?(key) }
+ .map { |l| "#{l}=*" }
+ .uniq
+ .filter_map do |target|
+ r = RichText.new("text", "foo #{target} bar")
+ links = Nokogiri::HTML::DocumentFragment.parse(r.to_html).css("a")
+ target if links.empty?
+ end
Would it be better to use `\p{Word}` to match unicode word characters rather than using `\w` to match ascii word characters and then trying to tag on chunks of the unicode code space?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6612#discussion_r2631847225
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6612/review/3593970493 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251218/be2f86ce/attachment.htm>
More information about the rails-dev
mailing list