[openstreetmap/openstreetmap-website] Link directions to routing engine demo (Issue #6387)

[Minh Nguyễn]

1ec5 left a comment (openstreetmap/openstreetmap-website#6387)

> the [Leaflet Routing Machine](https://github.com/perliedman/leaflet-routing-machine/) plugin we’re using

My bad, we aren’t use the Leaflet Routing Machine: #1262. Instead we have [our own homegrown abstraction](https://github.com/openstreetmap/openstreetmap-website/blob/db8748265138f6a1375ff565b71589e8497b50c6/app/assets/javascripts/index/directions.js#L6) with [adapters](https://github.com/openstreetmap/openstreetmap-website/tree/db8748265138f6a1375ff565b71589e8497b50c6/app/assets/javascripts/index/directions) for GraphHopper, OSRM, and Valhalla. Each adapter currently hard-codes a link to the routing provider as attribution:

https://github.com/openstreetmap/openstreetmap-website/blob/db8748265138f6a1375ff565b71589e8497b50c6/app/assets/javascripts/index/directions-route-output.js#L138-L140 https://github.com/openstreetmap/openstreetmap-website/blob/db8748265138f6a1375ff565b71589e8497b50c6/app/assets/javascripts/index/directions/graphhopper.js#L40 https://github.com/openstreetmap/openstreetmap-website/blob/db8748265138f6a1375ff565b71589e8497b50c6/app/assets/javascripts/index/directions/fossgis_valhalla.js#L61 https://github.com/openstreetmap/openstreetmap-website/blob/db8748265138f6a1375ff565b71589e8497b50c6/app/assets/javascripts/index/directions/fossgis_osrm.js#L155

We could supplement that link with a link to the full demo site. The code above already has access to all the parameters that we’d want to pass into the demo site.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6387#issuecomment-3672039463
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/6387/3672039463 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251218/dc291c0c/attachment.htm>