[openstreetmap/openstreetmap-website] Refactor embed.js.erb with layers.yml (PR #5571)
Marwin Hochfelsner
notifications at github.com
Sat Feb 1 05:18:26 UTC 2025
> The code changes here look great now but the commit history is rather messy - can we get rid of the merges please and rebase it instead? and merge any fixup commits into the thing they're fixing - having two `Refactor embed.js.erb with layers.yml` commits in one PR can't be right.
Well, I tried to and failed miserably, as you may have seen. I fixed it in another branch, but as PRs can't have the source branch changed, I opened #5580.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5571#issuecomment-2628782011
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5571/c2628782011 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250131/e5a51f4b/attachment.htm>
More information about the rails-dev
mailing list