[openstreetmap/openstreetmap-website] Remove unused visible_nodes hashes from api element controllers (PR #5584)

Anton Khorev notifications at github.com
Sat Feb 1 16:45:50 UTC 2025


There was a method called `to_xml_node` defined on way models. It had a cache parameter, and `visible_nodes` was passed as this parameter in https://github.com/openstreetmap/openstreetmap-website/commit/6300fa2a4fa717ef60f715a5303916b85d951c47. Later in https://github.com/openstreetmap/openstreetmap-website/commit/363155a2a86796d27ee9161f1ee9b74d6fa307e5 xml output was rewritten and `to_xml_node` was no longer used. The method was removed in https://github.com/openstreetmap/openstreetmap-website/commit/2b1bac1279e268c8e5fcca34c950f30d2c06ec1c. Same for relations.

However `visible_nodes` stayed. It's being written to but is never read.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5584

-- Commit Summary --

  * Remove unused visible_nodes hashes from api element controllers

-- File Changes --

    M app/controllers/api/relations_controller.rb (3)
    M app/controllers/api/ways_controller.rb (7)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5584.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5584.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5584
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5584 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250201/f2c6a4e3/attachment.htm>


More information about the rails-dev mailing list