[openstreetmap/openstreetmap-website] generate_share_url: wrong encoding for email title (Issue #5587)

[mmd]

### URL

_No response_

### How to reproduce the issue?

1. Pick random diary entry with spaces in title, e.g. https://www.openstreetmap.org/user/watmildon/diary/406063
2. Click on "Share via Email" button
3. Note that the title in your email client reads as "`OSM+US+Board+Candidate+Statement+2025`"

Issue: `title = URI.encode_www_form_component(title) `  is wrong encoding for email titles, it should probably be `URI.encode_uri_component`, which replaces space characters by %20

See https://stackoverflow.com/questions/68835994/how-to-have-a-subject-line-with-spaces-in-an-email-link

### Screenshot(s) or anything else?

_No response_

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5587
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/5587 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250201/a5e460b3/attachment.htm>