[openstreetmap/openstreetmap-website] Don't check ids of new notes in create note system tests (PR #5593)

[Anton Khorev]

If I'm making purely ui tests here I can't possibly know id of new notes, therefore I shouldn't check them.

But the actual reason is that it looks like `assert_content "Unresolved note ##{Note.last.id}"` line is sometimes reached before db writes are complete. `Note.last.id` is not going to have an expected value in these cases.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5593

-- Commit Summary --

  * Don't check ids of new notes in create note system tests

-- File Changes --

    M test/system/create_note_test.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5593.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5593.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5593
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5593 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250202/936f42d0/attachment-0001.htm>