[openstreetmap/openstreetmap-website] Adds optional use of note's author and description v2 (PR #5579)

Nenad Vujicic notifications at github.com
Tue Feb 4 01:00:48 UTC 2025


@nenad-vujicic commented on this pull request.



> +  def note_description(author, description, user_id, user_ip)
+    if !(user_id.nil? && user_ip.nil?) && !author.nil? && author.status == "deleted"
+      RichText.new("text", t("notes.show.description_when_author_is_deleted"))
+    else
+      description
+    end
+  end

Thanks for catching this! Fixed.

Also, reordered commits. Thanks!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5579#discussion_r1940334682
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5579/review/2591468131 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250203/6114c2e4/attachment.htm>


More information about the rails-dev mailing list