[openstreetmap/openstreetmap-website] Fix all no-implicit-globals eslint errors (PR #5613)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -1,21 +1,22 @@
-function openShareUrl(url, initialWidth = 640, initialHeight = 480) {
-  const width = Math.max(100, Math.min(screen.width, initialWidth));
-  const height = Math.max(100, Math.min(screen.height, initialHeight));
+(function () {
+  function openShareUrl(url, initialWidth = 640, initialHeight = 480) {

Can't this one be fixed by just moving the function inside the ready call, rather than adding another layer using the horrid IIFE syntax?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5613#pullrequestreview-2596643614
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5613/review/2596643614 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250205/8dea8442/attachment-0001.htm>