[openstreetmap/openstreetmap-website] Fixes bug when deleted user's note lacks comments (PR #5609)

Nenad Vujicic notifications at github.com
Thu Feb 6 11:12:59 UTC 2025


@nenad-vujicic commented on this pull request.



> @@ -52,10 +52,10 @@
     <% end %>
   </div>
 
-  <% if @note_comments.length > 1 %>
+  <% if @note_comments.length > (!@note.author.nil? && @note.author.status == "deleted" ? 0 : 1) %>

Fixed in the last push. Thanks!

Q: Do we need to replace current anonymous warning to something like "This note **is created by anonymous user or** includes comments from anonymous users **so** should be independently verified." or current message is good enough?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5609#discussion_r1944542717
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5609/review/2598366797 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250206/1582069f/attachment.htm>


More information about the rails-dev mailing list