[openstreetmap/openstreetmap-website] API element resources - nested elements (PR #5626)

Anton Khorev notifications at github.com
Thu Feb 6 14:01:27 UTC 2025


Creates nested resources instead of the following actions: `ways_for_node`, `relations_for_node`, `relations_for_way`, `relations_for_relation`. After that there's no nonstandard actions in api element controllers for current versions of elements.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5626

-- Commit Summary --

  * Declare api node ways as nested resources
  * Declare api node relations as nested resources
  * Declare api way relations as nested resources
  * Declare api relation relations as nested resources
  * Clean up after creating nested relation resources
  * Remove unnecessary RuboCop exclusions

-- File Changes --

    M .rubocop.yml (3)
    M app/abilities/api_ability.rb (4)
    A app/controllers/api/nodes/relations_controller.rb (25)
    A app/controllers/api/nodes/ways_controller.rb (25)
    A app/controllers/api/relations/relations_controller.rb (25)
    M app/controllers/api/relations_controller.rb (30)
    A app/controllers/api/ways/relations_controller.rb (25)
    M app/controllers/api/ways_controller.rb (16)
    A app/views/api/nodes/relations/index.json.jbuilder (5)
    A app/views/api/nodes/relations/index.xml.builder (5)
    A app/views/api/nodes/ways/index.json.jbuilder (5)
    A app/views/api/nodes/ways/index.xml.builder (5)
    A app/views/api/relations/relations/index.json.jbuilder (5)
    A app/views/api/relations/relations/index.xml.builder (5)
    D app/views/api/relations/relations_for_node.json.jbuilder (5)
    D app/views/api/relations/relations_for_node.xml.builder (5)
    D app/views/api/relations/relations_for_relation.json.jbuilder (5)
    D app/views/api/relations/relations_for_relation.xml.builder (5)
    D app/views/api/relations/relations_for_way.json.jbuilder (5)
    D app/views/api/relations/relations_for_way.xml.builder (5)
    A app/views/api/ways/relations/index.json.jbuilder (5)
    A app/views/api/ways/relations/index.xml.builder (5)
    D app/views/api/ways/ways_for_node.json.jbuilder (5)
    D app/views/api/ways/ways_for_node.xml.builder (5)
    M config/routes.rb (17)
    A test/controllers/api/nodes/relations_controller_test.rb (75)
    A test/controllers/api/nodes/ways_controller_test.rb (72)
    A test/controllers/api/relations/relations_controller_test.rb (69)
    M test/controllers/api/relations_controller_test.rb (109)
    A test/controllers/api/ways/relations_controller_test.rb (69)
    M test/controllers/api/ways_controller_test.rb (36)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5626.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5626.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5626
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5626 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250206/e704eba0/attachment-0001.htm>


More information about the rails-dev mailing list