[openstreetmap/openstreetmap-website] Set iD map param with array (PR #5632)
Marwin Hochfelsner
notifications at github.com
Sun Feb 9 16:30:44 UTC 2025
@hlfan commented on this pull request.
> } else if (id.data("lat") && id.data("lon")) {
- params.set("map", "16/" + id.data("lat") + "/" + id.data("lon"));
+ map = [null, id.data("lat"), id.data("lon")];
Yes, the secondary default value that was introduced in https://github.com/openstreetmap/openstreetmap-website/commit/6494747882358cc1506ae442c89eed3db1de94a4 seemed like an arbitrary deviation IMO.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5632#discussion_r1948144455
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5632/review/2604308521 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250209/2ff6e523/attachment-0001.htm>
More information about the rails-dev
mailing list