[openstreetmap/openstreetmap-website] Get directions using fetch (PR #5642)

Holger Jeromin notifications at github.com
Tue Feb 11 07:26:11 UTC 2025


@HolgerJeromin commented on this pull request.



> @@ -3,7 +3,8 @@
 //= require_tree ./directions
 
 OSM.Directions = function (map) {
-  var routeRequest = null; // jqXHR object of an ongoing route request or null
+  let awaitingRoute = false; // true if a route request is in progress

Do we really need both? The controller and the boolean?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5642#pullrequestreview-2607890078
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5642/review/2607890078 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250210/4d1a62f7/attachment.htm>


More information about the rails-dev mailing list